From e6546e85be8196df95b748115af7b599570953b4 Mon Sep 17 00:00:00 2001
From: mivirl <octoberstargazer7405@mivirl.dev>
Date: Thu, 16 Oct 2025 14:29:08 +0000
Subject: [PATCH] Add tests for argument splitting

---
 .../fixtures/crates/echo_arguments_1.0.tgz    | Bin 0 -> 713 bytes
 .../echo_arguments/echo_arguments-1.0.0.toml  |   9 +++
 testsuite/tests/edit/split-arguments/test.py  |  18 +++++
 .../tests/edit/split-arguments/test.yaml      |   4 +
 testsuite/tests/run/split-arguments/test.py   |  72 ++++++++++++++++++
 testsuite/tests/run/split-arguments/test.yaml |   4 +
 6 files changed, 107 insertions(+)
 create mode 100644 testsuite/fixtures/crates/echo_arguments_1.0.tgz
 create mode 100644 testsuite/fixtures/run_index/ec/echo_arguments/echo_arguments-1.0.0.toml
 create mode 100644 testsuite/tests/edit/split-arguments/test.py
 create mode 100644 testsuite/tests/edit/split-arguments/test.yaml
 create mode 100644 testsuite/tests/run/split-arguments/test.py
 create mode 100644 testsuite/tests/run/split-arguments/test.yaml

diff --git a/testsuite/fixtures/crates/echo_arguments_1.0.tgz b/testsuite/fixtures/crates/echo_arguments_1.0.tgz
new file mode 100644
index 0000000000000000000000000000000000000000..52281930349912b25a8203ed804e933643bfa445
GIT binary patch
literal 713
zcmV;)0yh00iwFP!000001MQYkPunmMfcu<ZamvHmO0-Lwrje+a#GnsFn?PgQ6H??R
zCJnT9<s_7!zjM;0Nuhu=U_#uds&Rbh^PSH=hX-@%GZke^F4E*{>n*Sl&vo_F_FSv}
zENR)U<qd7mb3D6c*@Kbow7`86Z+6I%lqmpwa`m*{)AA1rZ{|Ny!RzmVm*(H~EYEUA
zn15%8U6lWK;F0_{yZS7g{o@=u!K2}DU;b@p;O^w#v)o||tXGNf89sUb*Ks<B<B;`F
z<Z{VG=>LcX9~)KoZ+@Tp)AO-mtdtCRm?;huy+Mx44FYju06?z?aH04ec0sv$fZwl}
zNMb1ff9qH{1Fd?RkG}IKmGls%BIOZRaCijPSSzg*i<S&fN2(M$CkGFQ9f0ZkkzlDG
z<{S3TujVtmV`IjnSZGt%Qo$5r0XFpe4}$HNk@zPvL!TE?uJkCRwgCN$481Vh+HfHZ
zd9YxLZ{D<a8TBCqQsB12=4Gm45$UM*P79rBWwUa*Ks$b>9WQm;znF-4-NikQHlzTZ
zfF*qEVCSs6$y$T;oC|2T+i>&^%&WF}ut(!+qj9xQL#A`Cl3dAzFO7M-RjddXVIE7_
zh416Xmp)&z+WK!t>Q-|@j*b6)s6G%o^?#@KN2}MUdC$~;%NyC%_us%nJ$vNfH9+<M
z9l)x7!-MpZnr;;J=Tc@W;Qnch2O8G^&mevy6sJ&&&u4nL7Uxn^&Th<7Ho51)Rx*o4
zCHcv)s1?>8er;&u`3=B=TZYx{dloN3yc(*CmAi#ER50fWT3{hFyBll08_UFNp%>Na
z#AbZcD3;<?ym*P#s$8LUecAkB#SGY7Z<_i4`Ji473x%z!%v;yE*@D|1P7&PJJS?5r
vi8~fA4ttW+1I`DcF{+IOK@bE%5ClOG1VIo4K@bE%5TA~}6Y~Ff04M+e5UXdv

literal 0
HcmV?d00001

diff --git a/testsuite/fixtures/run_index/ec/echo_arguments/echo_arguments-1.0.0.toml b/testsuite/fixtures/run_index/ec/echo_arguments/echo_arguments-1.0.0.toml
new file mode 100644
index 00000000..1146fcdb
--- /dev/null
+++ b/testsuite/fixtures/run_index/ec/echo_arguments/echo_arguments-1.0.0.toml
@@ -0,0 +1,9 @@
+description = "Echo command-line arguments"
+name = "echo_arguments"
+version = "1.0.0"
+maintainers = ["mr@lazy.com"]
+maintainers-logins = ["mrlazy"]
+
+[origin]
+url = "file:../../../crates/echo_arguments_1.0.tgz"
+hashes = ["sha512:881ce9c2e9823e78f4f51d6ae5a7ad005b746495481f696f020c1f60d96b987aead778e864b8c2cba67e4d6ab13107b2e7fc6d3a24cbb9fa9c9247e16502a037"]
diff --git a/testsuite/tests/edit/split-arguments/test.py b/testsuite/tests/edit/split-arguments/test.py
new file mode 100644
index 00000000..5a96b89c
--- /dev/null
+++ b/testsuite/tests/edit/split-arguments/test.py
@@ -0,0 +1,18 @@
+"""
+Test `alr edit` argument splitting
+"""
+
+from drivers.alr import run_alr, init_local_crate
+from drivers.asserts import assert_match
+from subprocess import run
+
+import os, re, shutil
+
+init_local_crate()
+
+run_alr('settings', '--global', '--set', 'editor.cmd', 'sh -c "echo Argument splitting test"')
+
+p = run_alr('edit', quiet=False)
+assert_match('Argument splitting test', p.out, flags=re.S)
+
+print('SUCCESS')
diff --git a/testsuite/tests/edit/split-arguments/test.yaml b/testsuite/tests/edit/split-arguments/test.yaml
new file mode 100644
index 00000000..28f897d5
--- /dev/null
+++ b/testsuite/tests/edit/split-arguments/test.yaml
@@ -0,0 +1,4 @@
+driver: python-script
+indexes:
+    run_index:
+        in_fixtures: true
diff --git a/testsuite/tests/run/split-arguments/test.py b/testsuite/tests/run/split-arguments/test.py
new file mode 100644
index 00000000..dd661277
--- /dev/null
+++ b/testsuite/tests/run/split-arguments/test.py
@@ -0,0 +1,72 @@
+"""
+Test `alr run -a` argument splitting
+"""
+
+from drivers.alr import run_alr, CalledProcessError
+from drivers.asserts import assert_match
+from subprocess import run
+
+import os, re, shutil
+
+target = 'echo_arguments_1.0.0_filesystem'
+alr_path = os.environ['ALR_PATH']
+
+def check_run(arguments, match="", should_fail=False):
+    if not should_fail:
+        p = run_alr('run', '-a', arguments, quiet=not match, complain_on_error=not should_fail)
+        if match:
+            assert_match(match, p.out, flags=re.S)
+    else:
+        # Need to check stderr on failure, so using subprocess.run
+        p = run([alr_path, "run", "-a", arguments], capture_output=True)
+        if 0 == p.returncode:
+            raise CalledProcessError
+        if match:
+            assert_match(match, p.stderr.decode(), flags=re.S)
+
+p = run_alr('get', 'echo_arguments', quiet=True)
+os.chdir(target)
+
+# Split on spaces
+check_run('code example with spaces', match=".*'code'\n'example'\n'with'\n'spaces'")
+
+# Escaped spaces
+check_run('code\\ example\\ with\\ spaces', match=".*'code example with spaces'")
+
+# Unnecessary escapes
+check_run('\\c\\o\\d\\e \\example \\with \\s\\p\\a\\c\\e\\s', match=".*'code'\n'example'\n'with'\n'spaces'")
+
+# Double quotes
+check_run('code "example with" spaces', match=".*'code'\n'example with'\n'spaces'")
+
+# Single quotes
+check_run('code \'example with\' spaces', match=".*'code'\n'example with'\n'spaces'")
+
+# Escaped double quotes
+check_run('code \\"example with\\" spaces', match=".*'code'\n'\"example'\n'with\"'\n'spaces'")
+
+# Escaped single quotes
+check_run('code \\\'example with\\\' spaces', match=".*'code'\n'\\\\'example'\n'with\\\\''\n'spaces'")
+
+# Nested escaped double quotes
+check_run('code \"example \\\" with\" spaces', match=".*'code'\n'example \" with'\n'spaces'")
+
+# Escaped closing single quote (closing quote cannot be escaped)
+check_run('code \'example \\\' with spaces', match=".*'code'\n'example \\\\\\\\'\n'with'\n'spaces'")
+
+# Nested double & single quotes
+check_run('code \"example \'with spaces\'\"', match=".*'code'\n'example \\\\'with spaces\\\\''")
+
+# Unterminated escape should fail
+check_run('code example with spaces\\', match=".*Unterminated escape sequence in command:.*", should_fail=True)
+
+# Unterminated single quote should fail
+check_run('code example with \'spaces', match=".*Unterminated single quote sequence in command:.*", should_fail=True)
+
+# Unterminated double quote should fail
+check_run('code example with \"spaces', match=".*Unterminated double quote sequence in command:.*", should_fail=True)
+
+os.chdir('..')
+shutil.rmtree(target)
+
+print('SUCCESS')
diff --git a/testsuite/tests/run/split-arguments/test.yaml b/testsuite/tests/run/split-arguments/test.yaml
new file mode 100644
index 00000000..28f897d5
--- /dev/null
+++ b/testsuite/tests/run/split-arguments/test.yaml
@@ -0,0 +1,4 @@
+driver: python-script
+indexes:
+    run_index:
+        in_fixtures: true
-- 
2.39.5