]> _ Git - alire.git/commit
Cache lockfiles, remove Root global, and related refactorings (#690)
authorAlejandro R Mosteo <alejandro@mosteo.com>
Fri, 5 Mar 2021 14:46:56 +0000 (15:46 +0100)
committerGitHub <noreply@github.com>
Fri, 5 Mar 2021 14:46:56 +0000 (15:46 +0100)
commitb21b0d23725a52f3d4ab01c05c6f1eec01788d70
tree1608632289adaed2a50e759c01036adae10f35f9
parent30908899f6d2b37364808fd3d469c974cb059378
Cache lockfiles, remove Root global, and related refactorings (#690)

* Changes up to Alire.Roots

* Finished migrating from Workspace

* Root is stored in Alr.Commands.Command for reuse

This way the global Root is no longer reloaded many times, and modifications
are properly encapsulated via the Alire.Roots.Root type. This removes one of
the outstanding code smells in Alire.

* Speed-ups related to lockfile checks

There were a number of overkill checks that furthermore were expensive, loading
the lockfile many times. This became quite noticeable for large lockfiles (once
there is a decent number of dependencies).

* Minor tweaks to comments

* Tweaks after merging from master

Two big PRs were merged from upstream that created some friction with these
changes, requiring minor tweaks.

* Temporarily disable `alr build` CI check

To allow merging with changes in dependencies, temporarily disable the
aforementioned check.
37 files changed:
.github/workflows/ci-self.yml [deleted file]
.github/workflows/ci-self.yml.disabled [new file with mode: 0644]
deps/aaa
src/alire/alire-crate_configuration.adb
src/alire/alire-crate_configuration.ads
src/alire/alire-environment.adb
src/alire/alire-environment.ads
src/alire/alire-paths.ads
src/alire/alire-releases.adb
src/alire/alire-releases.ads
src/alire/alire-root.ads
src/alire/alire-roots-optional.adb
src/alire/alire-roots-optional.ads
src/alire/alire-roots.adb
src/alire/alire-roots.ads
src/alire/alire-workspace.adb [deleted file]
src/alire/alire-workspace.ads [deleted file]
src/alr/alr-commands-build.adb
src/alr/alr-commands-build.ads
src/alr/alr-commands-clean.adb
src/alr/alr-commands-edit.adb
src/alr/alr-commands-get.adb
src/alr/alr-commands-index.adb
src/alr/alr-commands-pin.adb
src/alr/alr-commands-printenv.adb
src/alr/alr-commands-publish.adb
src/alr/alr-commands-run.adb
src/alr/alr-commands-search.adb
src/alr/alr-commands-show.adb
src/alr/alr-commands-test.adb
src/alr/alr-commands-update.adb
src/alr/alr-commands-version.adb
src/alr/alr-commands-withing.adb
src/alr/alr-commands.adb
src/alr/alr-commands.ads
src/alr/alr-root.ads [deleted file]
testsuite/tests/workflows/action-command/test.py